Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading to 0.17.9 can't connect to any homeserver (proxy setting trouble) with new Electron setup #8229

Closed
szimszon opened this issue Jan 23, 2019 · 17 comments
Labels
A-Electron P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Platform-Specific

Comments

@szimszon
Copy link
Contributor

Description

After the upgrade from 0.17.8 to 0.17.9 we are not able to connect to homeserver (I see a magenta banner with Unable to connect to Homeserver. Retrying...). If I do nothing just start the 0.17.8 everything is fine.

Steps to reproduce

  • Upgrade from 0.17.8 to 0.17.9

kep

Version information

For the desktop app:

  • OS: Windows10 with corporate squid proxy
  • Version: 0.17.9
@szimszon
Copy link
Contributor Author

Okay I checked from another network without the proxy and everything is fine.
So it seems to me that the windows proxy settings and/or network proxy settings (http://wpad/wpad.dat) are not honored ;(

@szimszon szimszon changed the title After upgrading to 0.17.9 can't connect to any homeserver After upgrading to 0.17.9 can't connect to any homeserver (proxy setting trouble) with new Electron setup Jan 23, 2019
@t3chguy
Copy link
Member

t3chguy commented Jan 23, 2019

@szimszon
Copy link
Contributor Author

I know there are possibilities to do so ('--proxy-pac-url=' https://electronjs.org/docs/api/chrome-command-line-switches). All I say is it was working out of the box on ver. 0.17.8 and still works. To tinker with commandline parameters is not an option for us sorry.

@szimszon
Copy link
Contributor Author

I checked in the meantime and I'm not able to connect to the server even if I specify (in the app-0.17.9/Riot.exe) --proxy-server or --proxy-pac-url... :(

@szimszon szimszon changed the title After upgrading to 0.17.9 can't connect to any homeserver (proxy setting trouble) with new Electron setup [BUG][BigRegression][Usability Problem] After upgrading to 0.17.9 can't connect to any homeserver (proxy setting trouble) with new Electron setup Jan 24, 2019
@szimszon szimszon changed the title [BUG][BigRegression][Usability Problem] After upgrading to 0.17.9 can't connect to any homeserver (proxy setting trouble) with new Electron setup After upgrading to 0.17.9 can't connect to any homeserver (proxy setting trouble) with new Electron setup Jan 24, 2019
@szimszon
Copy link
Contributor Author

Could be related to #8232 ... and not proxy settings...

@szimszon
Copy link
Contributor Author

Now I modified the public_baseurl to the url without the :8443 but now on login I got CORS errors...

@dbkr
Copy link
Member

dbkr commented Jan 24, 2019

If I've understood correctly, you're seeing this as soon as v0.17.9 starts with an existing session, ie. not logging it at the Riot login screen? If so, I don't think this is related to #8232.

I'll try & test this in a bit: it could be an electron regression.

@szimszon
Copy link
Contributor Author

szimszon commented Jan 24, 2019

Now I have this:
kep

Still behind a corporate proxy.

@szimszon
Copy link
Contributor Author

Also there is no use if I try:
...\AppData\Local\riot\app-0.17.9\Riot.exe --proxy-pac-url=http://wpad/wpad.dat
or even
\AppData\Local\riot\app-0.17.9\Riot.exe --proxy-server=http://...

The same app (0.17.9) is running from Firefox as a charm. I needed to change the public_baseurl from ...hu:8443 to ...hu (without the :8443) but this is another story.

Desktop app 0.17.9 is still not working. ;(

@dbkr
Copy link
Member

dbkr commented Jan 25, 2019

Just tried to reproduce this and I was able to set a proxy server in Windows 10 settings and Riot picked it up and used it. I've just noticed that the error is showing as tunnel connection failed, so it looks like Riot is trying to use the proxy server but failing. Does your proxy server require auth of some kind? Perhaps this is what has broken.

@szimszon
Copy link
Contributor Author

Yes we need authentication for the proxy.
I think we have Negotiate as a means to authenticate to a squid proxy.
https://wiki.squid-cache.org/Features/NegotiateAuthentication

@floviolleau
Copy link

Hi,

The problem is not only related to electron I think.

I configured a different HS in the login page and for somewhat reason, some XHR calls still go to the default HS and are not using the HS I configured in the login page.

Any ideas?

Thanks

@jryans
Copy link
Collaborator

jryans commented Jan 28, 2019

I configured a different HS in the login page and for somewhat reason, some XHR calls still go to the default HS and are not using the HS I configured in the login page.

Is your issue related to proxies as well? If not, I would suggest filing a separate issue, as it sounds a bit different from the issue here.

@floviolleau
Copy link

I created #8300

@szimszon
Copy link
Contributor Author

The problem is still present with 1.0 ;(

@szimszon
Copy link
Contributor Author

Additionally I have seen when I put http:// instead of https:// (by mistake) I got Proxy Authentication Required error. Weird.

@lampholder lampholder added T-Defect Z-Platform-Specific P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Electron labels Feb 18, 2019
@szimszon
Copy link
Contributor Author

With version 1.2.0 Riot-web started working with proxy using https://wiki.squid-cache.org/Features/NegotiateAuthentication...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Platform-Specific
Projects
None yet
Development

No branches or pull requests

6 participants