Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+Left broken when pills present #7527

Closed
aidalgol opened this issue Oct 21, 2018 · 6 comments
Closed

Ctrl+Left broken when pills present #7527

aidalgol opened this issue Oct 21, 2018 · 6 comments
Labels
A-Pills P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@aidalgol
Copy link
Contributor

Description

Ctrl+Left when there is a pill in the message composer does not move the cursor left a word at a time, but instead moves only one character at a time.

Steps to reproduce

  1. Insert a pill for a user in the current room (either by clicking the user's name, or via tab-completion).
  2. Enter multiple words of text (e.g. Testing this bug.)
  3. Type Ctrl+Left and observe the cursor movement.

Version information

  • Platform: desktop
  • OS: Debian GNU/Linux 9.5
  • Version: 0.17.0 (installed via Flatpak from Flathub)
@aidalgol
Copy link
Contributor Author

I have not rolled back to a previous version to be 100% sure, but I think this is a regression in 0.17.0.

@aaronraimist
Copy link
Collaborator

Yes, seems to be related to upgrading Slate.

This feature works in v0.16.6 and is broken on /develop.

@aaronraimist aaronraimist mentioned this issue Oct 21, 2018
Closed
@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround type:composer labels Oct 23, 2018
@lampholder
Copy link
Member

On a mac, ctrl+left/right move to the start/end of line, and alt+left/right moves word by word. And both are broken in Riot.im composer when there's a pill in there (fine when there isn't).

@lampholder lampholder added the P1 label Oct 23, 2018
@rkfg
Copy link
Contributor

rkfg commented Oct 30, 2018

This seems to be fixed in 0.17.3 for me.

@aaronraimist
Copy link
Collaborator

Yes seems fixed for me as well. @lampholder ready to close?

@turt2live
Copy link
Member

Fixed here too. Closing.

@jryans jryans added the A-Pills label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Pills P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rkfg @jryans @turt2live @lampholder @aidalgol @aaronraimist