Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to remove user avatar is not handled gracefully #7202

Closed
spantaleev opened this issue Aug 20, 2018 · 1 comment
Closed

Failure to remove user avatar is not handled gracefully #7202

spantaleev opened this issue Aug 20, 2018 · 1 comment
Labels
A-Avatar A-User-Settings P2 T-Defect

Comments

@spantaleev
Copy link
Contributor

I can reproduce this on riot-web 0.16.0.

The problem happens when going to User Settings and trying to remove your avatar.

If the {"avatar_url": null} HTTP request to /_matrix/client/r0/profile/@user-id/avatar_url fails (in my case it fails with a 403 error for reasons which are expected and not related to this bug) the riot-web UI would not show any error message.

Even worse, it would display an empty avatar, as if removal really worked (while in actuality, it didn't). I'm guessing the latter is caused by optimistically removing the avatar for better UX, and never restoring it when the HTTP request fails.
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@t3chguy
Copy link
Member

t3chguy commented Jul 10, 2023

Closing in favour of #8632

@t3chguy t3chguy closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Avatar A-User-Settings P2 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @spantaleev @lampholder @t3chguy