Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot is unable to start correctly most times #6272

Closed
turt2live opened this issue Mar 1, 2018 · 7 comments
Closed

Riot is unable to start correctly most times #6272

turt2live opened this issue Mar 1, 2018 · 7 comments
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker
Milestone

Comments

@turt2live
Copy link
Member

Description

For the last few days I've been getting the prompt from Chrome to kill the tab repeatedly when refreshing/starting Riot. When looking at my CPU usage it's clear that Riot is stuck doing something, although my environment is refusing to let me profile it for whatever reason.

I've yet to come into a case where pressing "wait" instead of "kill page" actually gets Riot to load. I've had to kill the page and try again every time (usually it starts fine on the second or third attempt to open Riot).

The visible failure mode is that I'm able to see the spinner move (which makes sense - it's a gif), however I cannot interact with the page at all, open dev tools, etc.

Suggestions on how to actually profile this to get useful information would be appreciated.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 64
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder lampholder added T-Defect P1 X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Critical Prevents work, causes data loss and/or has no workaround X-Release-Blocker and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 6, 2018
@lukebarnard1
Copy link
Contributor

@turt2live has this improved recently?

@turt2live
Copy link
Member Author

@lukebarnard1 I see the prompt about 50% of the time when starting Riot for the first time in the morning, but otherwise it has decreased it's frequency significantly.

@ara4n
Copy link
Member

ara4n commented Mar 8, 2018

can you start a perf profile going the second you open it?

@turt2live
Copy link
Member Author

This is now #6060 for me - closing as the root issue described here is fixed.

@turt2live
Copy link
Member Author

Re-opening: I still get this when doing a sync for the first time in 1+ days (in my case, 3 days).

Not so long ago (January?) this kind of gap in time would cause things to slow down, but not so bad that Chrome wanted to kill the tab. In this case it is clearly related to some sort of Riot thing because the /sync request returns within a couple seconds, despite being a few days old.

I got a profile, but it doesn't actually reveal much (besides it stopped working and sat idle for over a minute). I've sent this profile to you directly @ara4n

@turt2live turt2live reopened this Mar 12, 2018
@lampholder lampholder added this to the 0.14 milestone Mar 13, 2018
@lampholder
Copy link
Member

Adding to 0.14 just to force the conversation about what needs to happen with this.

@turt2live
Copy link
Member Author

of course, since I've last complained the issue seemingly resolved itself (at least for the behaviour described in the OP). The remaining performance issues seem to be #6212 and #3307 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Development

No branches or pull requests

4 participants