Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ending backslash in displayed user name breaks mention badge. #4867

Closed
ZoomRmc opened this issue Aug 24, 2017 · 5 comments · Fixed by matrix-org/matrix-react-sdk#4411
Closed

Comments

@ZoomRmc
Copy link

ZoomRmc commented Aug 24, 2017

Description

Ending backslash in displayed user name breaks mention badge styling.

Steps to reproduce

  • Change the displayed user-name to something that ends with the backslash, e.g. user\
  • Mention such user
  • Get [user](https://matrix.to/#/@user:matrix.org): displayed, instead of a styled badge

Version information

  • Platform: Web, Android
    Checked in Firefox and Chrome.

  • Version: Web: 0.12.1 Android: 0.7.00

@lukebarnard1
Copy link
Contributor

Ah. We probably should escape user display names for inserting them into markdown.

@ZoomRmc
Copy link
Author

ZoomRmc commented Sep 2, 2017

Seems fixed in the web version.

@sandhose
Copy link
Member

sandhose commented Sep 2, 2017

I have the same issue with someone that has a backtick in his username. The two backticks in the pill (once in the link, once in the text) are interpreted as an inline code block.

image

Tested on develop and on stable.

@grahamperrin
Copy link

grahamperrin commented Sep 15, 2017

/develop/

For an IRC user [ade] at https://matrix.to/#/!GdmnfkDxuKZAICnOhe:matrix.org/$15055010117354830ilAZn:matrix.org:

2017-09-15 19 44 01 riot 2

Seems fixed in the web version.

Maybe not, or not for me. https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15054481726668574nPpFV:matrix.org for screenshots of a recent incident affecting an IRC user

Jan\

@sbts
Copy link

sbts commented Sep 28, 2017

Definitely still an issue for backticks in Nicks.
see #5135 for another example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants