-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FilePanel work with e2e crypto #3412
Comments
Done on the android client. |
as #3679 shows, this is a bit surprising - i'd expect the e2e contents to be decryptable in the sidepanel if they can be decrypted in the main panel! |
Is this deemed a wontfix? |
It's on the list of things to improve now that we have e2e by default. Anything we don't plan on fixing is closed. |
Am confused, we have this now powered by Seshat in riot-desktop. What's there to improve? |
Both filepanel and search need some kind of warning in Riot Web that nothing came up because you aren't using Riot Desktop. |
Sure, keeping in mind that rooms don't always start off encrypted so the plaintext ones still can exist and be shown |
Right but if the room is encrypted there should be a warning below any unencrypted items saying something along the lines of "There may be more files but Riot can't find them because..." |
I'm a bit confused. Isn't this issue about getting the FilePanel to show links to all files (rather than showing a notice about possibly missing files?) After all, the main message area can show the links, so I think users will be surprised if files may be missing in the FilePanel? |
This is already done in riot-desktop using Seshat as stated above. On riot-web it'd be a very expensive operation which might literally not be done and instead an explanation of why its infeasible and a link to riot-desktop might be provided instead., |
What are the acceptance criteria for this task being resolved? I have two related problems, but I'm not sure if this task covers them:
|
The desktop app should in theory support FilePanel in E2EE rooms these days. If it's not working there on some rooms, let's open a new bug to track it. |
We should extend the indexeddb stuff to let locally referenced attachments show up in FilePanel.
See also #2591
The text was updated successfully, but these errors were encountered: