Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FilePanel work with e2e crypto #3412

Closed
ara4n opened this issue Mar 11, 2017 · 12 comments
Closed

Make FilePanel work with e2e crypto #3412

ara4n opened this issue Mar 11, 2017 · 12 comments

Comments

@ara4n
Copy link
Member

ara4n commented Mar 11, 2017

We should extend the indexeddb stuff to let locally referenced attachments show up in FilePanel.

See also #2591

@ylecollen
Copy link

Done on the android client.

@ara4n
Copy link
Member Author

ara4n commented Apr 20, 2017

as #3679 shows, this is a bit surprising - i'd expect the e2e contents to be decryptable in the sidepanel if they can be decrypted in the main panel!

@thoraj
Copy link
Contributor

thoraj commented May 28, 2020

Is this deemed a wontfix?
With e2ee enabled by default perhaps this should be addressed?

@turt2live
Copy link
Member

It's on the list of things to improve now that we have e2e by default. Anything we don't plan on fixing is closed.

@t3chguy
Copy link
Member

t3chguy commented May 28, 2020

Am confused, we have this now powered by Seshat in riot-desktop. What's there to improve?

@aaronraimist
Copy link
Collaborator

Both filepanel and search need some kind of warning in Riot Web that nothing came up because you aren't using Riot Desktop.

@t3chguy
Copy link
Member

t3chguy commented May 28, 2020

Sure, keeping in mind that rooms don't always start off encrypted so the plaintext ones still can exist and be shown

@aaronraimist
Copy link
Collaborator

Right but if the room is encrypted there should be a warning below any unencrypted items saying something along the lines of "There may be more files but Riot can't find them because..."

@thoraj
Copy link
Contributor

thoraj commented May 28, 2020

I'm a bit confused.

Isn't this issue about getting the FilePanel to show links to all files (rather than showing a notice about possibly missing files?)

After all, the main message area can show the links, so I think users will be surprised if files may be missing in the FilePanel?

@t3chguy
Copy link
Member

t3chguy commented May 29, 2020

Isn't this issue about getting the FilePanel to show links to all files (rather than showing a notice about possibly missing files?)

This is already done in riot-desktop using Seshat as stated above. On riot-web it'd be a very expensive operation which might literally not be done and instead an explanation of why its infeasible and a link to riot-desktop might be provided instead.,

@kittykat
Copy link
Contributor

kittykat commented Aug 11, 2021

What are the acceptance criteria for this task being resolved? I have two related problems, but I'm not sure if this task covers them:

  1. element-web does not show me encrypted files in the FilePanel, but it does tell me to go use the desktop app (as mentioned above).

  2. The desktop app does not show me files for some encrypted rooms (I don't know when the encryption was enabled, but I suspect on room creation as it's now the default and the room is recent). The room's files menu not showing anything  #15318 could be a duplicate. Desktop app on left, web to the right:
    Screenshot from 2021-08-11 12-10-01

These same images show up in the right place on Android:
Screenshot_20210811-121332

@ara4n
Copy link
Member Author

ara4n commented Oct 13, 2021

The desktop app should in theory support FilePanel in E2EE rooms these days. If it's not working there on some rooms, let's open a new bug to track it.

@ara4n ara4n closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants