Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor away the complexity in EntityTile component #26493

Open
MidhunSureshR opened this issue Nov 2, 2023 · 0 comments
Open

Refactor away the complexity in EntityTile component #26493

MidhunSureshR opened this issue Nov 2, 2023 · 0 comments
Labels
A-Technical-Debt O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist

Comments

@MidhunSureshR
Copy link
Member

Your use case

We should remove some of the complexity from this component:

  1. We probably don't need both shouldShowPresence and suppressOnHover props, one should be enough since they're both used to enable/disable rendering presence.
  2. subtextLabel prop and the associated code for rendering it can also be removed since it's not used anywhere(?)

Have you considered any alternatives?

No response

Additional context

No response
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 3, 2023
@MidhunSureshR MidhunSureshR mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Technical-Debt O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andybalaam @MidhunSureshR