Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Export chat" feature doesn't respect 24-hours time format (forces AM / PM output) in plaintext mode #23838

Closed
nekohayo opened this issue Nov 25, 2022 · 6 comments · Fixed by matrix-org/matrix-react-sdk#10696
Labels
A-Export-Chat good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@nekohayo
Copy link

Steps to reproduce

  1. Click the room name at the top of the UI
  2. "Export chat", choose plaintext format

Outcome

What did you expect?

Output like this:

2022-11-15, 09:44:48 - bob left the room
2022-11-16, 22:59:22 - <jeff> alice: if you will need me to emergency smoke-test something with your branch this month?
2022-11-18, 08:28:16 - <alice> jeff: thanks, I've been testing with my xml from stable and finding a billion bugs.

What happened instead?

Hard-to-read (or to process) output like this:

2022-11-15, 9:44:48 a.m. - bob left the room
2022-11-16, 10:59:22 p.m. - jeff: alice: if you will need me to emergency smoke-test something with your branch this month?
2022-11-18, 8:28:16 a.m. - alice: jeff: thanks, I've been testing with my xml from stable and finding a billion bugs.

P.s.: the <speaker username> format that is part of my expected output style is explained in issue #23837

Operating system

Fedora 37

Browser information

Firefox 107

URL for webapp

app.element.io

Application version

Element version: 1.11.15, Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

No

@uhoreg uhoreg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Export-Chat good first issue Good for newcomers labels Nov 25, 2022
@github-actions github-actions bot added the Help Wanted Extra attention is needed label Nov 25, 2022
@jaydeep-radadiya
Copy link

Hello @uhoreg, @nekohayo

Can I take up this issue?

@nekohayo
Copy link
Author

Open source does not require permission for you to send patches / merge requests.

@uhoreg
Copy link
Member

uhoreg commented Jan 21, 2023

Some times it is a good idea to check before working on an issue, for example to see if someone else is already working on it, or if there are certain considerations that are relevant (e.g. design). In this case, it looks pretty straightforward, and I don't think there are any complications. But see also matrix-org/matrix-react-sdk#9724 (which attempts to solve this, but forces 24-hour time, and hasn't had any response from the contributor).

@nawarajshah
Copy link

i have made changes, and waiting for PR to be reviewed

@rashmitpankhania
Copy link

isnt the datetime format depends on user's locale
is the expectation from this issue to stick on one format i.e 2022-11-18, 08:28:16 ??

@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2023

@rashmitpankhania check out Settings > Preferences > Displaying time

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Export-Chat good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
6 participants