Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting from the markdown bar breaks formatting #2197

Closed
AmandineLP opened this issue Sep 14, 2016 · 6 comments
Closed

Quoting from the markdown bar breaks formatting #2197

AmandineLP opened this issue Sep 14, 2016 · 6 comments
Labels
A-Composer P2 T-Defect X-Needs-Community-Testing X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@AmandineLP
Copy link
Contributor

AmandineLP commented Sep 14, 2016

I copy pasted a bunch of text including paragraphs and line breaks, selected it all, clicked on the 'quote' button and all my formatting was lost, putting everything as a single line text

@lukebarnard1
Copy link
Contributor

It seems that the default behaviour when quoting in draft-js is to quote every "block". So bullets will become individual blockquotes instead of there being one big blockquote encapsulating all. Inline formatting appears to survive however.

@DJCrashdummy
Copy link

i guess this is related:
i observed that quoting messages with numbering just works until the numbering because the numbers (including its text) is ignored. ☹️

no idea if it is the same for bullets. - i will report if i fall across such case (and still remember).

@yannicka
Copy link

yannicka commented Mar 28, 2021

From my side, the composer does not break the formatting, it is the formatted message that is badly formatted.

Original message:

a

b

I select all and I click on the "Quote" button:

> a
> 
> b

I send the message.

The message is displayed as:

> ab

And if I edit the message, the content is:

> 
ab

The source of the message sent:

{
  "type": "m.room.message",
  "content": {
    "msgtype": "m.text",
    "body": "> a\n>\n> b",
    "format": "org.matrix.custom.html",
    "formatted_body": "<blockquote>\nab\n</blockquote>\n"
  }
}

body is correct while formatted_body is incorrect.

@MazeChaZer
Copy link

This is still broken because of #8786

@t3chguy
Copy link
Member

t3chguy commented Dec 3, 2021

@MazeChaZer would you consider this fixed now then?

@t3chguy t3chguy added X-Needs-Info This issue is blocked awaiting information from the reporter and removed Z-RTE labels Dec 3, 2021
@kittykat
Copy link
Contributor

I'm going to close this for now as it appears to be fixed. Please file a new issue with details if you feel that there are further improvements to be made 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer P2 T-Defect X-Needs-Community-Testing X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

9 participants