-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend quick settings #20623
Comments
Ftr we do also have high contrast and deployments can have more themes defined via config.json and users can add custom themes via labs. @niquewoodhouse does this impact this design at all? |
Yes, I think it negatively impacts it - I think the above picker makes sense for two themes but not if there's more than 3. |
@niquewoodhouse what do we want to do here? Close the issue as we can have more themes? Or show different UIs based on number of themes? @t3chguy what does the theme switcher in the user menu at the top do when a user has 3 themes? |
Breaks, always just toggles between Light & Dark, ignoring the default set via config.json |
In general, I think it would be good to avoid different UIs for the number of themes so I'd personally bias towards closing issue. |
I'm going to close as this works as expected |
Small amends to quick settings based on testing iA element-hq/element-meta#56
Tasks
ele-web-quick-settings-01.mp4
Future tasks we might consider worth doing
Notes
1 I've put the designs here. I think there might already be something like this in screensharing in video call, but not sure. @t3chguy I'd like to personally go with the alternative option (which doesn't use accent colour), but I leave it with @nadonomy to review.
The text was updated successfully, but these errors were encountered: