Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend quick settings #20623

Closed
3 tasks
Tracked by #19707
niquewoodhouse opened this issue Jan 18, 2022 · 6 comments
Closed
3 tasks
Tracked by #19707

Amend quick settings #20623

niquewoodhouse opened this issue Jan 18, 2022 · 6 comments
Assignees
Labels
T-Enhancement Z-IA Issues relating to information architecture Z-Labs

Comments

@niquewoodhouse
Copy link

niquewoodhouse commented Jan 18, 2022

Small amends to quick settings based on testing iA element-hq/element-meta#56

Tasks

  • Amend theme picker to be easier to switch between the two options (we don't seem to be anywhere near having more themes, so....why not make it a bit easier as it's supposed to be quick to use settings)1
ele-web-quick-settings-01.mp4

Future tasks we might consider worth doing

  • Clarify if theme picker should remain in user menu also
  • Discover if there are other settings a user might want quick access to, or if none, discuss amending title to not be 'quick settings'

Notes

1 I've put the designs here. I think there might already be something like this in screensharing in video call, but not sure. @t3chguy I'd like to personally go with the alternative option (which doesn't use accent colour), but I leave it with @nadonomy to review.

@niquewoodhouse niquewoodhouse added T-Enhancement Z-IA Issues relating to information architecture Z-Labs labels Jan 18, 2022
@t3chguy
Copy link
Member

t3chguy commented Jan 18, 2022

Ftr we do also have high contrast and deployments can have more themes defined via config.json and users can add custom themes via labs. @niquewoodhouse does this impact this design at all?

@niquewoodhouse
Copy link
Author

Ftr we do also have high contrast and deployments can have more themes defined via config.json and users can add custom themes via labs. @niquewoodhouse does this impact this design at all?

Yes, I think it negatively impacts it - I think the above picker makes sense for two themes but not if there's more than 3.

@kittykat
Copy link
Contributor

@niquewoodhouse what do we want to do here? Close the issue as we can have more themes? Or show different UIs based on number of themes?

@t3chguy what does the theme switcher in the user menu at the top do when a user has 3 themes?

@t3chguy
Copy link
Member

t3chguy commented Jan 27, 2022

@t3chguy what does the theme switcher in the user menu at the top do when a user has 3 themes?

Breaks, always just toggles between Light & Dark, ignoring the default set via config.json

@niquewoodhouse
Copy link
Author

@niquewoodhouse what do we want to do here? Close the issue as we can have more themes? Or show different UIs based on number of themes?

In general, I think it would be good to avoid different UIs for the number of themes so I'd personally bias towards closing issue.

@kittykat
Copy link
Contributor

I'm going to close as this works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Z-IA Issues relating to information architecture Z-Labs
Projects
None yet
Development

No branches or pull requests

3 participants