Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threads List Panel creates two thread events on new thread instead of one #19397

Closed
Palid opened this issue Oct 14, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6949
Closed

Threads List Panel creates two thread events on new thread instead of one #19397

Palid opened this issue Oct 14, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6949
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@Palid
Copy link
Contributor

Palid commented Oct 14, 2021

Steps to reproduce

  1. Login to two accounts (Alice and Bob) and join the same room with both of them
  2. Make Alice open Thread List
  3. Make Bob send a message and then create a thread from it
  4. See that two threads are created instead of one.

The root message was "groot", followup message creating the thread was "I am groot".
Image below:
CleanShot 2021-10-14 at 15 32 49@2x

Outcome

What did you expect?

Expected behavior was that only "groot", root message would be created

What happened instead?

Both "groot" and "I am groot" messages were created.

Fixing #19395 can probably fix this one as well, as the problem occurs due to changing root event.

Operating system

No response

Browser information

No response

URL for webapp

No response

Homeserver

No response

Will you send logs?

No
@Palid Palid added T-Defect A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Oct 14, 2021
@germain-gg germain-gg mentioned this issue Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make threads use 'm.thread' relation matrix-org/matrix-react-sdk
1 participant
@Palid