Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include "reset all" link in the Access Secret Storage dialog if it's in the context of the verification dialog #19288

Open
duxovni opened this issue Oct 5, 2021 · 0 comments
Labels
Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ T-Task Tasks for the team like planning

Comments

@duxovni
Copy link
Contributor

duxovni commented Oct 5, 2021

(Splitting this off from #19279 , which covered several independent UI bugs found while reviewing matrix-org/matrix-react-sdk#6811)

Now that the new device verification dialog has its own reset button, when you choose to verify using your recovery key/phrase, it's awkward for the resulting dialog to also have a reset button. Allow that UI component to be turned off if it's in a context where it's redundant/unnecessary.

@duxovni duxovni self-assigned this Oct 5, 2021
@germain-gg germain-gg added the T-Task Tasks for the team like planning label Oct 6, 2021
@duxovni duxovni added this to the App Team 1.9.2 milestone Oct 6, 2021
@duxovni duxovni added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

2 participants