Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EventIndex crawler to discover threads timelines #19197

Closed
3 tasks
germain-gg opened this issue Sep 28, 2021 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2089
Closed
3 tasks

Update EventIndex crawler to discover threads timelines #19197

germain-gg opened this issue Sep 28, 2021 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2089
Assignees
Labels

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Sep 28, 2021

matrix-react-sdk/src/indexing/EventIndex.ts is the abstraction built over seshat to crawl through events in e2ee rooms.

It leverages the js-sdk events to discover rooms and timelines and will then individually process events and add them to the message index.

We need to rework to EventIndex to make it discover the threads timelines so that it can index the messages

Once all the messages have been indexed, we should go ahead and disable threads labs flag and ensure that we don't need to crawl through the events again. We shouldn't need to as seshat is unaware of threads and it shouldn't ever be aware of them

Requirements

  • After login into Element having threads enabled, seshat should parse and index all events (threaded and non-threaded)
  • After disabling threads, previously indexed events that are part of a thread should still show up in the search results
  • Indexed events should have a way to identify them as part of a thread so that the UI layer can render them differently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants