Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VoiceRecording.ts uses noiseSuppression preventing TypeScript upgrade #19048

Closed
dbkr opened this issue Sep 15, 2021 · 1 comment
Closed

VoiceRecording.ts uses noiseSuppression preventing TypeScript upgrade #19048

dbkr opened this issue Sep 15, 2021 · 1 comment
Labels
A-Developer-Experience T-Task Tasks for the team like planning

Comments

@dbkr
Copy link
Member

dbkr commented Sep 15, 2021

src/audio/VoiceRecording.ts uses noiseSuppression attribute which was removed (microsoft/TypeScript-DOM-lib-generator#1029).

Review whether to stop using this or add it to our types.
@dbkr dbkr added the T-Task Tasks for the team like planning label Sep 15, 2021
@dbkr dbkr mentioned this issue Sep 15, 2021
Closed
@t3chguy
Copy link
Member

t3chguy commented Nov 16, 2022

4.5 brought it back microsoft/TypeScript-DOM-lib-generator#1143

@t3chguy t3chguy closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@germain-gg @dbkr @t3chguy