Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make matrix.to links open the thread view #18954

Closed
4 tasks done
germain-gg opened this issue Sep 9, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7003
Closed
4 tasks done

Make matrix.to links open the thread view #18954

germain-gg opened this issue Sep 9, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7003
Assignees
@germain-gg
Labels
A-Threads T-Task Tasks for the team like planning
Milestone
App Team 1.9.4

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Sep 9, 2021 •
edited
Loading

For a threaded event to be considered open after clicking a link, the timeline with that event should be loaded and the target event should be within the viewport and highlighted (notice the green highlight on the left of the screenshot below)

Screen Shot 2021-10-06 at 15 03 17

Scenarios to consider for matrix.to links

  • Clicking on a link from a third-party website
  • Clicking on a matrix.to from Element
  • Clicking on a web notification toast
  • Reloading Element when it has an event ID in its URL
@germain-gg germain-gg added T-Task Tasks for the team like planning A-Threads labels Sep 9, 2021
@germain-gg germain-gg added this to the App Team 1.8.4 milestone Sep 10, 2021
@novocaine novocaine modified the milestones: App Team 1.8.6, App Team 1.8.7 Sep 22, 2021
@novocaine novocaine mentioned this issue Sep 25, 2021
Closed
@daniellekirkwood daniellekirkwood mentioned this issue Sep 29, 2021
Closed
@germain-gg germain-gg mentioned this issue Oct 6, 2021
Closed
5 tasks
@germain-gg germain-gg removed this from the App Team 1.9.2 milestone Oct 13, 2021
@Palid
Copy link
Contributor

Palid commented Oct 15, 2021

Probably related: #19404

@germain-gg germain-gg mentioned this issue Oct 16, 2021
Closed
@germain-gg germain-gg self-assigned this Oct 19, 2021
@germain-gg germain-gg added this to the App Team 1.9.4 milestone Oct 19, 2021
This was referenced Oct 21, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads T-Task Tasks for the team like planning
Projects
None yet
Milestone
App Team 1.9.4
Development

Successfully merging a pull request may close this issue.

Implement deep-linking for threads (matrix.to) matrix-org/matrix-react-sdk
4 participants
@novocaine @germain-gg @Palid @daniellekirkwood