Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger images in timeline are being cut off on the right #18163

Closed
BurnyBoi opened this issue Jul 21, 2021 · 5 comments
Closed

Larger images in timeline are being cut off on the right #18163

BurnyBoi opened this issue Jul 21, 2021 · 5 comments
Labels
A-Media A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@BurnyBoi
Copy link

BurnyBoi commented Jul 21, 2021

Description

Ever since upgrading to Element 1.7.33, larger images in the timeline are cut off on the right side, and the "download" link is no longer visible. In order to view the whole image, I have to click the image now.

Steps to reproduce

  • Upload a large image (particularly a wide one) to the message timeline

In the previous version of Element, images would shrink to fit the message bubble, so it was always fully shown.

Here's how it looks in 1.7.33:
image

And here's what it looks like in 1.7.32:
image

This might be related to #18162

Tested on Element Web 1.7.33-53-g5ec0ca91-dirty

@robintown
Copy link
Member

The download link being gone is intentional, as it has moved to the message action bar: matrix-org/matrix-react-sdk#6386

@turt2live
Copy link
Member

matrix-org/matrix-react-sdk#6386 didn't make it into the release, so it's extra cut off

@robintown
Copy link
Member

Well, it sounds to me like @BurnyBoi is actually running develop and not the release, given that the commit sha in the report is from today

@turt2live
Copy link
Member

ah, that would do it.

@robintown robintown added the S-Minor Impairs non-critical functionality or suitable workarounds exist label Jul 22, 2021
@robintown
Copy link
Member

Appears to be fixed as of matrix-org/matrix-react-sdk#6448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Media A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Development

No branches or pull requests

3 participants