Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification when someone with the same/similar name is referenced #16863

Closed
besendorf opened this issue Apr 5, 2021 · 3 comments
Closed

Notification when someone with the same/similar name is referenced #16863

besendorf opened this issue Apr 5, 2021 · 3 comments
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Spec-Changes Z-GetYourUpdates

Comments

@besendorf
Copy link
Contributor

besendorf commented Apr 5, 2021

Description

I noticed that when someone posts a reply to someone with the same display name as myself Element notifies me as if it was a reply to my post(text in red and a sound notification)

Steps to reproduce

  • have three users (A,B,C) in the same room
  • set display name for A to: "user" and display name for B to "User"
  • A writes "hello"
  • C replys to A's message
  • B gets a notification

Describe how what happens differs from what you expected.

You should only be notified when a reply is sent to your message. You should of course be also notified when your display name is mentioned in the body of a message, but not in the header of the message like the display name of someone else with a similar name.

Version information

only tested on desktop. Should be the same for web

desktop app:

Element version: 1.7.24

@SimonBrandner SimonBrandner added A-Notifications Z-Papercuts Visible. Impactful. Predictable to action. labels Apr 7, 2021
@ShadowJonathan
Copy link
Contributor

Isn't this related to reply fallbacks? And these notifications happening due to a "fuzzy search" in those.

@t3chguy
Copy link
Member

t3chguy commented Apr 20, 2021

The push rules behaviour is defined in the Matrix Spec and executed by both the Server & Client.

Related #8497 #9302

@nadonomy nadonomy removed the Z-Papercuts Visible. Impactful. Predictable to action. label May 18, 2021
@MadLittleMods MadLittleMods added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 12, 2022
@t3chguy
Copy link
Member

t3chguy commented Apr 25, 2023

Closing in favour of element-hq/element-meta#886

@t3chguy t3chguy closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Spec-Changes Z-GetYourUpdates
Projects
None yet
Development

No branches or pull requests

7 participants