Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention or username pill without avatar is too narrow, cuts off username, and is vertically mis-aligned … #15081

Open
fooness opened this issue Sep 2, 2020 · 2 comments
Labels

Comments

@fooness
Copy link
Contributor

fooness commented Sep 2, 2020

When turning off Show avatars in user and room mentions in Element, the surrounding background of resulting mentions or username pills, are too narrow and cut off the username to the left …

Screenshot 2020-09-02 at 08 21 34

Also username and the text don’t share the same baseline, i.e. they are vertically not aligned.

This could be fixed rather elegantly with removing the (in my opinion) unnecessary background color, setting the line-height and vertical-alignment to default and e.g. using text-decoration underline for the pill …

Screenshot 2020-09-02 at 08 25 08

PS: Which would also work pretty well for mentions or username pills WITH the avatar … and would be way better for readability and textflow, see also: #14794

Screenshot 2020-09-02 at 08 31 28

@t3chguy
Copy link
Member

t3chguy commented Sep 2, 2020

using text-decoration underline for the pill …

Then how would it be distinct from user-entered underlined text?
image

@fooness
Copy link
Contributor Author

fooness commented Sep 2, 2020

Personally, I wouldn’t care about this difference.

It was just a proposal, though. At least the old pill should be fixed at some point, please. If not some better solution to which all agree could be found.

@jryans jryans removed the Z-UI/UX label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants