Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/invite doesn't force terms with older homeservers #10746

Open
jryans opened this issue Sep 4, 2019 · 1 comment
Open

/invite doesn't force terms with older homeservers #10746

jryans opened this issue Sep 4, 2019 · 1 comment
Labels
A-Identity-Server Privacy T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Sep 4, 2019

With an older homeserver that doesn't yet use v2 IS APIs with terms (such as Synapse before matrix-org/synapse#5786), Riot won't trigger IS terms agreement when using /invite with an email (as it just sends a request to Synapse).

This is a different Riot code path from the address picker invite UI flow, as that currently talks directly to the IS so that Riot can present profile info as part of autocomplete the user via 3PID.
@jryans jryans added phase:3 and removed phase:2 labels Sep 18, 2019
@jryans
Copy link
Collaborator Author

jryans commented Sep 30, 2019

We could simplify the thinking here by using the same code path as the address picker and handling the IS interaction client-side.

@jryans jryans added phase:2 and removed phase:3 labels Sep 30, 2019
@jryans jryans added phase:3 and removed phase:2 labels Oct 29, 2019
@jryans jryans removed defect labels Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Identity-Server Privacy T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @Johennes