test that decline event gets sent

Signed-off-by: Timo K <[email protected]>

Author: toger5

src/toasts/IncomingCallToast.tsx

@@ -80,9 +80,9 @@ function JoinCallButtonWithCall({ onClick, call, disabledTooltip }: JoinCallButt
 }
 
 interface DeclineCallButtonWithNotificationEventProps {
-    notificationEvent: MatrixEvent;
-    room?: Room;
     onDeclined: (e: ButtonEvent) => void;
+    notificationEvent: MatrixEvent;
+    room: Room | null;
 }
 
 function DeclineCallButtonWithNotificationEvent({
@@ -142,11 +142,12 @@ export function IncomingCallToast({ notificationEvent }: Props): JSX.Element {
 
     // Stop ringing on dismiss.
     const dismissToast = useCallback((): void => {
-        if (!notificationEvent.getId()) {
+        const notificationId = notificationEvent.getId();
+        if (!notificationId) {
             logger.warn("Could not get eventId for RTCNotification event");
             return;
         }
-        ToastStore.sharedInstance().dismissToast(getIncomingCallToastKey(notificationEvent.getId()!, roomId));
+        ToastStore.sharedInstance().dismissToast(getIncomingCallToastKey(notificationId, roomId));
         LegacyCallHandler.instance.pause(AudioID.Ring);
     }, [notificationEvent, roomId]);
 
@@ -248,6 +249,7 @@ export function IncomingCallToast({ notificationEvent }: Props): JSX.Element {
                     onClick={(e) => {
                         onJoinClick(e);
                     }}
+                    role="button"
                 >
                     <div className="mx_IncomingCallToast_message">
                         <VideoCallIcon width="20px" height="20px" style={{ position: "relative", top: "4px" }} />{" "}

test/test-utils/test-utils.ts

@@ -204,6 +204,7 @@ export function createTestClient(): MatrixClient {
         sendTyping: jest.fn().mockResolvedValue({}),
         sendMessage: jest.fn().mockResolvedValue({}),
         sendStateEvent: jest.fn().mockResolvedValue(undefined),
+        sendRtcDecline: jest.fn().mockResolvedValue(undefined),
         getSyncState: jest.fn().mockReturnValue("SYNCING"),
         generateClientSecret: () => "t35tcl1Ent5ECr3T",
         isGuest: jest.fn().mockReturnValue(false),

test/unit-tests/toasts/IncomingCallToast-test.tsx

@@ -19,6 +19,7 @@ import {
     EventType,
     RoomEvent,
     type IRoomTimelineData,
+    type ISendEventResponse,
 } from "matrix-js-sdk/src/matrix";
 import { type ClientWidgetApi, Widget } from "matrix-widget-api";
 import { type IRTCNotificationContent } from "matrix-js-sdk/src/matrixrtc";
@@ -394,4 +395,30 @@ describe("IncomingCallToast", () => {
             ),
         );
     });
+
+    it("sends a decline event when clicking the decline button and only dismiss after sending", async () => {
+        (toastStore.dismissToast as Mock).mockReset();
+
+        renderToast();
+
+        const { promise, resolve } = Promise.withResolvers<ISendEventResponse>();
+        client.sendRtcDecline.mockImplementation(() => {
+            return promise;
+        });
+
+        fireEvent.click(screen.getByRole("button", { name: "Decline" }));
+
+        expect(toastStore.dismissToast).not.toHaveBeenCalledWith(
+            getIncomingCallToastKey(notificationEvent.getId()!, room.roomId),
+        );
+        expect(client.sendRtcDecline).toHaveBeenCalledWith("!1:example.org", "$notificationEventId");
+
+        resolve({ event_id: "$declineEventId" });
+
+        await waitFor(() =>
+            expect(toastStore.dismissToast).toHaveBeenCalledWith(
+                getIncomingCallToastKey(notificationEvent.getId()!, room.roomId),
+            ),
+        );
+    });
 });