Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Improve user guidance during QR code login #2558

Closed
6 tasks done
mxandreas opened this issue Oct 8, 2024 · 5 comments
Closed
6 tasks done

[Story] Improve user guidance during QR code login #2558

mxandreas opened this issue Oct 8, 2024 · 5 comments

Comments

@mxandreas
Copy link

mxandreas commented Oct 8, 2024

Description

Currently the scanning the QR code with EX and showing the QR code on EW device for login are only available on the nightly builds. The reason for that is that MAS (which is a prerequisite for the QR code login) is not yet available in most homeservers.

However, it is assumed that deploying MAS on various homeservers will span across a long period of time (and some homeservers may not ever get it), it is desired to make it more clear for the users that this function depends on something their homeserver does not (yet) have.

In iterations with @amshakal @americanrefugee we landed on the following:

  • On EX intro screen, add a subtle hint: "Only available if your account provider supports it"
  • On EW,
    • Always show the Avatar > Link new device menu item, and if not supported, then instead of showing the QR code, show that it is not supported (designs below).
    • In the Settings > Sessions show always the Link new device section but disable the Show QR code button when not supported and add a text that it is not supported (designs below).

This would allow us to release the QR code login in the publish/production versions.

Acceptance criteria

No response

Leads

Size estimate

S

Dependencies

  • None

Out of scope

  • Nothing

Open questions

Questions

No tasks being tracked yet.

Subtasks

Android

  1. T-Task
    bmarty
  2. PR-Change Z-NextRelease

iOS

  1. T-Task
  2. pr-feature

Web

  1. T-Enhancement X-Upcoming-Release-Blocker
    t3chguy

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
@pmaier1
Copy link
Contributor

pmaier1 commented Oct 8, 2024

Makes sense to me (apart from the fact that only a tiny fraction of users out there use a homeserver that actually supports QR code login 🤷‍♂️).

@mxandreas
Copy link
Author

mxandreas commented Oct 8, 2024

@americanrefugee Has done the design updates for both EX and EW side:

image

@bmarty
Copy link
Member

bmarty commented Oct 9, 2024

I have added the string screen_qr_code_login_initial_state_subtitle to localazy (@element-hq/element-x-ios-reviewers)

@mxandreas
Copy link
Author

For visibility. It was confirmed that the desired changes on EW take more effort (and can't be released as part of the security release) due to the fact that we can't simply un-lab all the functionality (and need to do it just for the QR code parts).

Since it is now known that this is overall feasible (just delayed by a week), I proposed we continue with the release of EX as planned (e.g. showing the QR code login button), given we have a warning/hint that it needs to be supported by the account provider.

cc @daniellekirkwood @manuroe @t3chguy @pmaier1

@manuroe
Copy link
Member

manuroe commented Oct 23, 2024

Changes in EW are available in prod since yesterday. We can close this work.
Thanks all!

@manuroe manuroe closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants