Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pill mentions don't ping users if they're all mashed together #1617

Closed
non-Jedi opened this issue Sep 26, 2017 · 4 comments
Closed

pill mentions don't ping users if they're all mashed together #1617

non-Jedi opened this issue Sep 26, 2017 · 4 comments
Labels
A-Notifications A-Pills P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@non-Jedi
Copy link

non-Jedi commented Sep 26, 2017

If there's no space between pill mentions, none of the users mentioned will receive a notification.

e.g. <&Adam> <Half-Shot> is fine, but no notification for <&Adam><Half-Shot>

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Notifications P1 and removed P2 labels Sep 27, 2017
@lukebarnard1
Copy link

This is because the notifications are based on the non-HTML part of the message event. Ideally they should be based on parsing the HTML for display names in pills or otherwise

@non-Jedi
Copy link
Author

non-Jedi commented Nov 9, 2017

I disagree with making notifications only work by parsing html
(notifications happen at the protocol level, right?). In my mind the root of
the issue is that the html representation is showing separation that doesn't
exist in the plain-text representation. I'd be more in favor of doing
something like representing pillification in plain text as or
something.

Alternatively, maybe it's better for displayname notifications work off of
an additional piece of metadata in content? Something like:

{
    "body": "FooBar: here's the message",
    "notify_keywords": ["Foo", "Bar"]
}

@lampholder lampholder added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 12, 2018
@jryans jryans added the A-Pills label Jun 23, 2020
@t3chguy t3chguy transferred this issue from element-hq/element-web May 12, 2023
@t3chguy
Copy link
Member

t3chguy commented May 12, 2023

This will be fixed by Intentional Mentions cc @clokep

@clokep
Copy link
Contributor

clokep commented May 12, 2023

Yes, after MSC3952 mentions won't be parsed from the text body, but from metadata attached to the event. We can close this.

@clokep clokep closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Pills P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants