Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Search bar (that's actually a filter) to Filter #5250

Closed
daniellekirkwood opened this issue Dec 6, 2021 · 5 comments · Fixed by #5520
Closed

Rename Search bar (that's actually a filter) to Filter #5250

daniellekirkwood opened this issue Dec 6, 2021 · 5 comments · Fixed by #5520
Assignees
@aringenbach @daniellekirkwood
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021 •
edited
Loading

Problem

There's 2 places to "search" next to each other next to each other but they are 2 different actions.

Solution

Rename the filter to Filter in order to differentiate it from Search functionality.

Screenshot 2021-12-13 12 40 50
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort labels Dec 6, 2021
@daniellekirkwood daniellekirkwood self-assigned this Dec 13, 2021
@daniellekirkwood
Copy link
Contributor Author

Something like this...

Screenshot 2021-12-13 12 43 47

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@aringenbach aringenbach self-assigned this Feb 2, 2022
@aringenbach
Copy link
Contributor

Hello @daniellekirkwood

I think it might be misleading to have magnifying glass icon on both these options, the user can't quite understand that the top-right search functionality is something else.

We could reuse for example this icon or something else you would have in mind ?

@daniellekirkwood
Copy link
Contributor Author

Great suggestion!

@amshakal WDYT?

@daniellekirkwood daniellekirkwood added Z-WTF WTF issues: High impact, Low Effort and removed Z-WTF WTF issues: High impact, Low Effort labels Feb 7, 2022
@daniellekirkwood
Copy link
Contributor Author

We confirmed in Office Hours today that this is the correct icon, however this colour should be Grey when not in use (Amsha will add Figma)

@amshakal
Copy link

amshakal commented Feb 7, 2022

Looks good to me. Here is the link to the icon for colour: https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=1373%3A13

TY

@daniellekirkwood daniellekirkwood mentioned this issue Feb 7, 2022
Closed
@aringenbach aringenbach mentioned this issue Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aringenbach aringenbach

@daniellekirkwood daniellekirkwood

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update filter placeholder and icon element-hq/element-ios
3 participants
@aringenbach @amshakal @daniellekirkwood