Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing pages from Firefox only shares their title #2163

Closed
spantaleev opened this issue Jan 9, 2019 · 6 comments · Fixed by #2234
Closed

Sharing pages from Firefox only shares their title #2163

spantaleev opened this issue Jan 9, 2019 · 6 comments · Fixed by #2234
Labels
P3 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems UX X-Regression
Milestone

Comments

@spantaleev
Copy link
Contributor

Reproducible on 0.7.11 (TestFlight).

Using the "Share Page With..." feature in Firefox only shares the title of the page. The URL is not included in the message.

Downgrading to riot-ios 0.7.8 shows that it's working fine there (both page title and URL are included in the message).

So this seems to be some regression that happened after 0.7.8.

If sharing is done from Safari, it works identically in both 0.7.8 and 0.7.11 -- only the URL is part of the message (not the page title). Maybe that's a limitation caused by the payload that Safari delivers to riot-ios. In any case, it's the URL that is important, so Safari is fine.

@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P3 UX X-Regression labels Jan 16, 2019
@manuroe manuroe added this to the Sprint 18 milestone Jan 16, 2019
@manuroe
Copy link
Member

manuroe commented Jan 18, 2019

Other complaints on 0.7.11:

With the latest TestFlight version I have serious problems with the sharing feature on all apps.

Using the share button in an app (news, navigation, notes etc) to send something to a person it's now more or less random if it's sent. Sometimes it is, sometimes not, sometimes only an empty line.

Seems this got broken!

(https://matrix.to/#/!tDRGDwZwQnlkowsjsm:matrix.org/$15477975392407pzIte:flairy.de?via=matrix.org&via=disroot.org&via=riot.tenx.tech)

@fridtjof
Copy link
Contributor

fridtjof commented Jan 29, 2019

Just for quick access: a diff between v0.7.8 and v0.7.11:

vector-im:v0.7.8...v0.7.11

edit: fixed the link

@fridtjof
Copy link
Contributor

After stepping through the release diffs, I am pretty sure this is either caused by a change in MatrixKit, or by a change between v0.7.9 and v0.7.10 (diff:
vector-im:v0.7.9...v0.7.10), as nothing except version numbers and two trivial XCode warnings were fixed in the other releases.

@aaronraimist
Copy link
Contributor

Yeah almost all of the important changes happen in either matrix-is-sdk or matrix-ios-kit

@fridtjof
Copy link
Contributor

The relevant diffs of MatrixKit and MatrixSDK:

matrix-org/matrix-ios-kit@v0.9.1...v0.9.3

matrix-org/matrix-ios-sdk@v0.12.0...v0.12.1

@jacotec
Copy link

jacotec commented Feb 3, 2019

Unfortunately the issue is still present in 0.7.12, basically no sharing of any URLs from apps are working. They only produce an empty line at the receiver.

Was working fine prior to 0.7.11 ... we use it a lot and would be happy to see it fixed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems UX X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants