Implement Mobile Device Manager feature with 3 keys. #8698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganfra
approved these changes
Dec 4, 2023
| @@ -168,6 +173,11 @@ import javax.inject.Singleton | |||
| return Matrix(context, configuration) | |||
| } | |||
|
|
|||
| @Provides | |||
There was a problem hiding this comment.
You should use @Singleton otherwise listeners won't be kept.
Also use @Binds instead of @Provides
There was a problem hiding this comment.
Done in 6452b5c, hence I think it was fine since the listener was added and removed by the same entity (the Activity).
OK for you?
|
SonarCloud Quality Gate failed.
|
giomfo
reviewed
Dec 11, 2023
vector/src/main/java/im/vector/app/features/onboarding/OnboardingViewModel.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Add support for MDM with the following keys:
im.vector.app.serverConfigDefaultHomeserverUrlStringim.vector.app.serverConfigSygnalAPIUrlStringim.vector.app.clientPermalinkBaseUrliOS PR: element-hq/element-ios#7667
Motivation and context
Support MDM.
Internal issue: https://github.com/vector-im/element-internal/issues/527
Screenshots / GIFs
Tests
Cannot test using a real MDM configuration, but can be tested by hacking the method getData to return a custom string.
I have tested by returning a value for
MdmData.DefaultHomeserverUrldifferent frommatrix.organd the application was correctly defaulting to the provided homeserver.Also currently when the MDM configuration change, this is a no-op on the application. We may consider logging out the user.
Tested devices
Checklist