-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust Crypto SDK is now the default, and the build will replace the existing application #8390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bma/crypto_rust_default
branch
from
May 8, 2023 13:37
bb31a2d
to
f1036d4
Compare
…isting application.
…isting application.
bmarty
force-pushed
the
feature/bma/crypto_rust_default
branch
from
May 9, 2023 20:12
8baa485
to
421d996
Compare
@BillCarsonFr I have rebased the branch and removed the temporary commit. Also added a changelog entry at 421d996 I let you merge the PR once the CI is happy? |
bmarty
added
the
Z-NextRelease
For issues and PRs which should be included in the NextRelease.
label
May 9, 2023
BillCarsonFr
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Enable usage of Crypto Rust SDK.
Motivation and context
Share crypto code with other Element client!
Screenshots / GIFs
Tests
Tested devices
Checklist