Keep screen on while recording voicebroadcast #8313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostyle
requested review from
a team and
Florian14
and removed request for
a team
yostyle
changed the title
yostyle
changed the title
Florian14
reviewed
Apr 12, 2023
| @@ -103,6 +105,7 @@ class VoiceBroadcastRecorderQ( | |||
|
|
|||
| override fun startRecord(roomId: String) { | |||
| super.startRecord(roomId) | |||
| playbackTracker.updateCurrentRecording(AudioMessagePlaybackTracker.RECORDING_ID, emptyList()) | |||
There was a problem hiding this comment.
You should call playbackTracker.stopPlayback() when stopping the recording (it will change the playback state to IDLE) or rename the existing method/add a new one.
Eventually also call stopPlayback on pause & updateCurrentRecording on resume
There was a problem hiding this comment.
I added the tracker on stop. I don't prefer to manage pause state for the moment.
yostyle
force-pushed
the
yostyle/keep_screenon_vb_recording
branch
from
3c6492a
to
baa64cc
Compare
yostyle
force-pushed
the
yostyle/keep_screenon_vb_recording
branch
from
baa64cc
to
2506d95
Compare
yostyle
force-pushed
the
yostyle/keep_screenon_vb_recording
branch
from
2506d95
to
b2cbffc
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
When you start a recording it will stop when the display timeout is triggerd. We should have a wake lock in this case.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist