Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maunium sticker picker loads indefinitely on new update #8026

Closed
catfromplan9 opened this issue Jan 28, 2023 · 8 comments
Closed

Maunium sticker picker loads indefinitely on new update #8026

catfromplan9 opened this issue Jan 28, 2023 · 8 comments
Labels
A-Stickers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression

Comments

@catfromplan9
Copy link

catfromplan9 commented Jan 28, 2023

Steps to reproduce

  1. Where are you starting? What can you see?
    Chat view
  2. What do you click?
    Sticker button
  3. More steps…
    N/A

Outcome

What did you expect?

Sticker picker view loads and i can pick a sticker to send

What happened instead?

Indefinite loading of the sticker picker view. Works fine after downgrading to 1.5.11. Also, unrelated but I don't want to make another PR for this and it's technically not a bug: can you revert the image viewer to the pre-1.5.18 behaviour? What I mean is that when I open an image if I slide down on the image a little I used to be able to see the chat window and messages behind it but now it's blank and this means that whenever I view a video or photo file if I'm scrolled up in the chat after exiting the photo/video I'll immediately be jumped to the bottom and lose my position in the chat

Your phone model

Pixel 5a

Operating system version

Android 13.0

Application version and app store

Element version 1.5.20, F-Droid

Homeserver

Synapse 1.75.0

Will you send logs?

No

Are you willing to provide a PR?

No

@catfromplan9 catfromplan9 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 28, 2023
@Trendyne
Copy link
Contributor

Also happening to me and my friend on the latest FDroid version (1.5.20) and Synapse 1.75.0

  • Xiaomi Redmi Note 10 Pro (sweet) Android 13
  • Samsung A52 (LineageOS) Android 12

Restarting the app and trying to access stickers shows no entry in the NGINX log

@catfromplan9
Copy link
Author

Also happening to me and my friend on the latest FDroid version (1.5.20) and Synapse 1.75.0

* Xiaomi Redmi Note 10 Pro (sweet) Android 13

* Samsung A52 (LineageOS) Android 12

Restarting the app and trying to access stickers shows no entry in the NGINX log

I downgraded the app and it works fine. Definitely a client-sided issue. Contributors could check the commits made between versions on related code to narrow down what broke it

@ramshackle-heather
Copy link

This issue is occurring for us, as well, on a Pixel 5 running Android 13 and the latest F-Droid release of Element (1.5.22). Maunium sticker packs still work fine on our self-hosted web client (Element 1.11.15), but not on mobile.

@whaever
Copy link

whaever commented Feb 9, 2023

Same here - On a Oneplus 8 Pro (Android 13) and a Xiaomi Redmi Note 8 Pro (Android 12), the problem persists after updating Element to the newest fdroid version (1.5.22).

@jonnyandrew jonnyandrew added A-Stickers S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 15, 2023
@Destroyer
Copy link

Can we also mark this as regression?

@sebix
Copy link

sebix commented Mar 17, 2023

It worked prior to the mentioned version, so it's likely a regression I think

@yostyle
Copy link
Contributor

yostyle commented Mar 27, 2023

The problem appeared after this PR #7917 included in 1.5.20 release.

@TomicekRosic
Copy link

TomicekRosic commented Mar 30, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Stickers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression
Projects
None yet
Development

No branches or pull requests

9 participants