-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MSC3912 to delete server side all the data of a deleted voice broadcast #7988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian14
force-pushed
the
yostyle/msc3912
branch
from
January 24, 2023 10:42
ae03d00
to
0704fc5
Compare
Florian14
requested review from
a team and
mnaturel
and removed request for
a team and
Florian14
January 24, 2023 10:45
Florian14
changed the title
Draft MSC3912
Implement MSC3912 to delete server side all the data of a deleted voice broadcast
Jan 24, 2023
Florian14
added
the
Z-NextRelease
For issues and PRs which should be included in the NextRelease.
label
Jan 24, 2023
mnaturel
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have just added small comments and questions.
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/auth/version/Versions.kt
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/EventRedactBody.kt
Outdated
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/tasks/RedactEventTask.kt
Outdated
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/EventRedactBody.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/RoomAPI.kt
Outdated
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/tasks/RedactEventTask.kt
Outdated
Show resolved
Hide resolved
...android/src/main/java/org/matrix/android/sdk/internal/session/room/send/RedactEventWorker.kt
Outdated
Show resolved
Hide resolved
...android/src/main/java/org/matrix/android/sdk/internal/session/room/send/RedactEventWorker.kt
Outdated
Show resolved
Hide resolved
...ndroid/src/main/java/org/matrix/android/sdk/internal/session/room/send/queue/QueueMemento.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/home/room/detail/TimelineViewModel.kt
Show resolved
Hide resolved
bmarty
reviewed
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some further remarks.
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/auth/version/Versions.kt
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/tasks/RedactEventTask.kt
Outdated
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/EventRedactBody.kt
Outdated
Show resolved
Hide resolved
...android/src/main/java/org/matrix/android/sdk/internal/session/room/send/RedactEventWorker.kt
Outdated
Show resolved
Hide resolved
...android/src/main/java/org/matrix/android/sdk/internal/session/room/send/RedactEventWorker.kt
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
bmarty
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7967