Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC3912 to delete server side all the data of a deleted voice broadcast #7988

Merged
merged 12 commits into from
Jan 25, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Jan 20, 2023

@Florian14 Florian14 marked this pull request as ready for review January 24, 2023 10:43
@Florian14 Florian14 requested review from a team and mnaturel and removed request for a team and Florian14 January 24, 2023 10:45
@Florian14 Florian14 changed the title Draft MSC3912 Implement MSC3912 to delete server side all the data of a deleted voice broadcast Jan 24, 2023
@Florian14 Florian14 added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jan 24, 2023
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have just added small comments and questions.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further remarks.

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.0% 15.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants