Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Broadcast - Rework internal media players coordination #7979

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

Florian14
Copy link
Contributor

@Florian14 Florian14 commented Jan 19, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Rework internal media player coordination:
    Fix multiple media player created in the same time
    Properly cancel and release media player in preparation if needed
  • Remove some legacy code related to the live listening (we don't need to check anymore the playback position)
  • Fix playback restart handling

Motivation and context

Prevent potential media player leaked and improve voice broadcast playback

Screenshots / GIFs

Tests

  • Play voice broadcasts (live & ended)
  • Change the current voice broadcast in the fly, play with the buttons

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 added the A-Voice Broadcast Broadcast-style voice messages label Jan 19, 2023
@ElementBot

This comment was marked as outdated.

@Florian14 Florian14 force-pushed the bugfix/fre/rework_vb_media_player branch from a325681 to 19a489b Compare January 20, 2023 07:20
@ElementBot

This comment was marked as outdated.

@Florian14 Florian14 marked this pull request as ready for review January 20, 2023 07:26
@Florian14 Florian14 requested review from a team and ganfra and removed request for a team January 20, 2023 07:26
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jan 20, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM (not tested)!

Base automatically changed from bugfix/fre/fix_vb_scrubbing to develop January 23, 2023 13:22
@Florian14 Florian14 merged commit 1e951cd into develop Jan 23, 2023
@Florian14 Florian14 deleted the bugfix/fre/rework_vb_media_player branch January 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice Broadcast Broadcast-style voice messages Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants