Delete unused client information from account data (PSG-871) #7754
Conversation
onurays
requested review from
a team and
mnaturel
and removed request for
a team
| ) | ||
| } | ||
|
|
||
| internal class DefaultDeleteUserAccountDataTask @Inject constructor( |
There was a problem hiding this comment.
We could add unit tests on this class.
| return realmSessionProvider.withRealm { realm -> | ||
| realm | ||
| .where(UserAccountDataEntity::class.java) | ||
| .contains(UserAccountDataEntityFields.TYPE, type) |
There was a problem hiding this comment.
I think we should use beginsWith instead of contains if we want to reflect the method name.
| import org.matrix.android.sdk.api.session.crypto.model.DeviceInfo | ||
| import javax.inject.Inject | ||
|
|
||
| class DeleteUnusedClientInformationUseCase @Inject constructor( |
There was a problem hiding this comment.
I think we should put this class in the package core.session.clientinfo with the other classes about MatrixClientInfo.
| * limitations under the License. | ||
| */ | ||
|
|
||
| package im.vector.app.features.settings.devices.v2 |
There was a problem hiding this comment.
This test class should also be moved to core.session.clientinfo package.
| private val activeSessionHolder: ActiveSessionHolder, | ||
| ) { | ||
|
|
||
| suspend fun execute(deviceInfoList: List<DeviceInfo>) { |
There was a problem hiding this comment.
Maybe we should wrap the implementation using a runCatching and return a Result to avoid having the parent coroutine scope to be cancelled in case of network error (e.g. delete api not supported)?
| @@ -102,6 +105,9 @@ class UnknownDeviceDetectorSharedViewModel @AssistedInject constructor( | |||
| ) { cryptoList, infoList, pInfo -> | |||
| // Timber.v("## Detector trigger ${cryptoList.map { "${it.deviceId} ${it.trustLevel}" }}") | |||
| // Timber.v("## Detector trigger canCrossSign ${pInfo.get().selfSigned != null}") | |||
|
|
|||
| deleteUnusedClientInformation(infoList) | |||
There was a problem hiding this comment.
I guess we should add a unit test on this ViewModel to cover this use case.
|
Kudos, SonarCloud Quality Gate passed! |
onurays
deleted the
feature/ons/remove_client_information_account_data
branch
Type of change
Content
With new session manager implementation we started to store information of user devices in account data. If user logouts / delete a session we need to delete the corresponding client information to keep the account data as clean as possible. Backend has now a new endpoint to be able to delete account data events. This PR implements this feature.
Motivation and context
Implement MSC-3391
Screenshots / GIFs
Tests
account_data/io.element.matrix_client_information.DEVICETested devices
Checklist