-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice Broadcast - Update last message in the room list #7719
Conversation
ceeaaa9
to
5a257be
Compare
…st previewable event
fix factory
5a257be
to
59859ec
Compare
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me.
There is however quite a bit of new logic but no tests added/changed. Is it worth adding some (at least for the Matrix SDK)?
Thanks for your review @jonnyandrew , we agree about your remark about the missing tests |
Type of change
Content
Display "Live broadcast" in the room list if a VB is live
Show a notice in the room list and in the timeline when a voice broadcast is ended
Improve RoomSummary.latestPreviewableEvent computation in the sdk:
Note: For the moment, voice messages related to a VB are not filtered out on the sdk side, if the computed
latestPreviewableEvent
is a VB message, the application will just display a blank instead.Motivation and context
Continue #7127
Design request:
Screenshots / GIFs
voice_broadcast_last_message.mp4
Tests
Tested devices
Checklist