Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notifications setting when m.local_notification_settings.<device-id> event changes for current device #7632

Closed
mnaturel opened this issue Nov 23, 2022 · 0 comments · Fixed by #7692
Closed

Update notifications setting when m.local_notification_settings.<device-id> event changes for current device #7632

mnaturel opened this issue Nov 23, 2022 · 0 comments · Fixed by #7692
Assignees
@mnaturel
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Nov 23, 2022 •
edited
Loading

Your use case

What would you like to do?

When we detect a change on m.local_notification_settings.<device-id> event for the current session, it should update the notifications toggle setting.

Why would you like to do it?

To support client using background sync (see #7596)

How would you like to achieve it?

Listen for changes in the account data event in priority. Listen for pusher changes if no related account data for the current session.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Nov 23, 2022
@mnaturel mnaturel self-assigned this Nov 23, 2022
@mnaturel mnaturel mentioned this issue Dec 2, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
1 participant
@mnaturel