Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Broadcast - Show start voice broadcast errors in a dialog #7485

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

Florian14
Copy link
Contributor

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

Display a dialog if the user cannot start a voice broadcast (no permission, another user already recording in the room, user is already recording a voice broadcast)

Motivation and context

Continue #7127

Screenshots / GIFs

Permission Other user is recording User already recording
Screenshot_20221028_101706 Screenshot_20221028_101659 Screenshot_20221028_101649

Tests

Try starting a voice broadcast in the several contexts

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 requested review from a team and ericdecanini and removed request for a team October 28, 2022 08:54
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I tested all scenario to trigger errors : OK

Base automatically changed from feature/fre/voice_broadcast_player_interface to resilience-rc October 31, 2022 09:55
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

28.6% 28.6% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 merged commit 48cca99 into resilience-rc Oct 31, 2022
@Florian14 Florian14 deleted the feature/fre/start_voice_broadcast_error branch October 31, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants