Add metrics plugin to track device download keys task #7438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkma
requested review from
a team and
mnaturel
and removed request for
a team
BillCarsonFr
requested changes
Oct 31, 2022
| */ | ||
| @OptIn(ExperimentalContracts::class) | ||
| inline fun <T> measureMetric(metricMeasurementPlugins: List<MetricPlugin>, block: () -> T): T { | ||
| contract { |
There was a problem hiding this comment.
what's contract? Do we really need it (i can see it's experimental)
There was a problem hiding this comment.
It is basically a way to tell the compiler about how the function behaves. Sometimes the compiler doesn't know or is not fully aware of certain conditions or returns. So you can specify an effect when a function is invoked to help the compiler.
In our case, it allows us to write this code:
val response: KeysQueryResponse
measureMetric(plugin) {
response = block() // this won't be possible without contracts.
}
...-android/src/main/java/org/matrix/android/sdk/api/metrics/DownloadDeviceKeysMetricsPlugin.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/extensions/MetricsExtensions.kt
Outdated
Show resolved
Hide resolved
vector-app/src/main/java/im/vector/app/core/di/SingletonModule.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/analytics/metrics/VectorPlugins.kt
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
MetricsPluginis added which is implemented byVectorMetricsPlugin.Motivation and context
download_device_keysis one of such metrics.Tests
download_device_keysincreasing here.Tested devices
Checklist
- [ ] UI change has been tested on both light and dark themes- [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility- [ ] Pull request includes screenshots or videos if containing UI changes- [ ] Pull request includes a sign off- [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()