Handle properly when getUser returns null - prefer using getUserOrDefault #7372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…retrieve data asynchronously. So ensure that the initial state can always be built.
…o bulk insertion.
bmarty
added
the
Z-NextRelease
bmarty
commented
Oct 14, 2022
| userItem = it, | ||
| isMine = userId == session.myUserId | ||
| ) | ||
| } ?: return super.initialState(viewModelContext) |
There was a problem hiding this comment.
Defaulting to super.initialState(viewModelContext) make the app crash because there is no default constructor for DeviceListViewState
bmarty
changed the title
|
(not compiling, I will iterate) |
bmarty
requested review from
a team and
mnaturel
and removed request for
a team
|
SonarCloud Quality Gate failed. |
mnaturel
reviewed
Oct 17, 2022
Yes, done, sorry the previous description was not complete, and I did not create a dedicated issue about the crash. A few reports with this crash are coming from the PlayStore, and it can hard to reproduce locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
getUser can return null, since the loading of profile is now async. It may lead to unexpected issue and a crash, fixed by this commit: 0a6d620
Other commits fixes similar things. Also when retrieved, the profile is now stored into DB for future usage.
Motivation and context
Screenshots / GIFs
Tests
To reproduce the crash (but this is not 100% reproducible due to race condition)
Tested devices
Checklist