Support for login by m.login.token during QR code sign in #7358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Oct 13, 2022
There was a problem hiding this comment.
LGTM, some remark, which may be handled later.
Also when there is new API on the SDK, it's good to add a changelog file with .sdk extension. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog for more details.
thanks!
| @@ -404,6 +406,22 @@ internal class DefaultAuthenticationService @Inject constructor( | |||
| ) | |||
| } | |||
|
|
|||
| override suspend fun loginUsingQrLoginToken( | |||
| homeServerConnectionConfig: HomeServerConnectionConfig, | |||
| loginToken: String, | |||
There was a problem hiding this comment.
Is it possible to pass all the data from the QR code here? So that the SDK can handle the next step automatically?
There was a problem hiding this comment.
At this point we don't actually have the full context yet, so it probably doesn't make sense to do this.
We can look at the overall implementation once done and see what refactoring to do.
...k-android/src/main/java/org/matrix/android/sdk/internal/auth/DefaultAuthenticationService.kt
Outdated
Show resolved
Hide resolved
bmarty
approved these changes
Oct 14, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist
Signed-off-by: Hugh Nimmo-Smith [email protected]