Remove Arrow-kt dependency #7335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
Oct 11, 2022
| @Throws | ||
| fun writeToFile(data: ByteArray, file: File) { | ||
| file.sink().buffer().use { | ||
| it.write(data) |
There was a problem hiding this comment.
Those 2 fun are actually not used, but I do not want to delete this file.
bmarty
requested review from
a team and
ganfra
and removed request for
a team
|
I think we should get rid of Arrow as it's just used for some Option. We have our own simple Optional type in the sdk, could we replace? |
…il.Optional` instead.
bmarty
force-pushed
the
feature/bma/upgrade_arrow
branch
from
8d3c1db
to
1669316
Compare
|
OK, I have removed this dep. Thanks to review again the PR! |
bmarty
commented
Oct 12, 2022
| fun getOrNull(): T? { | ||
| return value | ||
| } | ||
| fun orNull(): T? = value |
There was a problem hiding this comment.
just a new alias to avoid to many changes.
bmarty
commented
Oct 12, 2022
| @@ -33,23 +31,19 @@ data class Optional<T : Any> constructor(private val value: T?) { | |||
| } | |||
| } | |||
|
|
|||
| fun getOrElse(fn: () -> T): T { | |||
| fun orElse(fn: () -> T): T { | |||
bmarty
commented
Oct 12, 2022
| } | ||
| } | ||
|
|
||
| fun <T : Any> T?.toOption() = Optional(this) |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Arrow-kt dependency.
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist