Local Notification Settings Event #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdecanini
changed the base branch from
develop
to
feature/eric/notificaton-settings-enabled
…ifications # Conflicts: # vector/src/main/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewAction.kt # vector/src/main/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewFragment.kt # vector/src/main/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewModel.kt # vector/src/main/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewState.kt # vector/src/main/res/layout/fragment_session_overview.xml # vector/src/test/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewModelTest.kt
…ic/notificaton-settings-enabled # Conflicts: # vector/src/test/java/im/vector/app/core/pushers/PushersManagerTest.kt
…ic/notificaton-settings-enabled
…/eric/local_notification_settings
…ic/notificaton-settings-enabled
…/eric/local_notification_settings
…ic/notificaton-settings-enabled
…/eric/local_notification_settings
…ic/notificaton-settings-enabled
…/eric/local_notification_settings
…ic/notificaton-settings-enabled
…/eric/local_notification_settings
…icaton-settings-enabled # Conflicts: # vector/src/test/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewModelTest.kt # vector/src/test/java/im/vector/app/test/fakes/FakePushersService.kt
…/eric/local_notification_settings
onurays
suggested changes
Oct 12, 2022
| @@ -28,4 +28,5 @@ object UserAccountDataTypes { | |||
| const val TYPE_IDENTITY_SERVER = "m.identity_server" | |||
| const val TYPE_ACCEPTED_TERMS = "m.accepted_terms" | |||
| const val TYPE_OVERRIDE_COLORS = "im.vector.setting.override_colors" | |||
| const val TYPE_LOCAL_NOTIFICATION_SETTINGS = "m.local_notification_settings" | |||
There was a problem hiding this comment.
This need to unstable prefix. Please see the bottom of the MSC-3890
| val currentSession = activeSessionHolder.getActiveSession() | ||
| viewModelScope.launch { | ||
| currentSession.accountDataService() | ||
| .getLiveUserAccountDataEvent(UserAccountDataTypes.TYPE_LOCAL_NOTIFICATION_SETTINGS) |
There was a problem hiding this comment.
Do we need to add device_id at the end of the UserAccountDataTypes.TYPE_LOCAL_NOTIFICATION_SETTINGS type according to the MSC?
Base automatically changed from
feature/eric/notificaton-settings-enabled
to
develop
October 12, 2022 13:27
onurays
approved these changes
Oct 12, 2022
…_notification_settings
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Handles the client side of using the LocalNotificationSettings event to remotely toggle an account's notifications
Motivation and context
Epic https://element-io.atlassian.net/browse/PSG-595
Closes https://element-io.atlassian.net/browse/PSG-779
Screenshots / GIFs
N/A
Tests
The account data event can only be sent from web build from https://element-io.atlassian.net/browse/PSG-709 so this was tested locally by making changes in the code forcing the silenced value to
falseTested devices
Checklist