-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice Broadcast - Add a feature flag with the composer action #7258
Conversation
b98d968
to
2812b16
Compare
|
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM,
I approved it as a first reviewer. @bmarty I let you review it for a final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks.
only show a toast for the moment
I think there is only a log for now. But this is fine :)
The tooltip is something else.
Type of change
Content
Note: added a todo for the permission check which will be added in a dedicated PR about voice broadcast permissions
Motivation and context
#7127
Screenshots / GIFs
Tested devices
Checklist