[Device Manager] Extend user agent to include device information (PSG-755) #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
requested review from
a team and
fedrunov
and removed request for
a team
onurays
requested review from
a team and
bmarty
and removed request for
fedrunov and
a team
bmarty
approved these changes
Sep 28, 2022
| "; Flavour " + flavorDescription + | ||
| "; MatrixAndroidSdk2 " + BuildConfig.SDK_VERSION + ")" | ||
| } | ||
| userAgent = computeUserAgentUseCase.execute(context, matrixConfiguration.applicationFlavor) |
There was a problem hiding this comment.
The context should be injected in ComputeUserAgentUseCase constructor instead.
changelog.d/7209.feature
Outdated
| @@ -0,0 +1 @@ | |||
| [Device Manager] Extend user agent to include device information | |||
There was a problem hiding this comment.
Since the change is SDK side only, I would use .sdk extension.
| Timber.e(e, "## initUserAgent() : failed") | ||
| } | ||
|
|
||
| val systemUserAgent = System.getProperty("http.agent") |
There was a problem hiding this comment.
Thanks for the removal of this part.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
User agent string improved by adding device information like:
Element dbg/1.5.0-dev (Xiaomi Mi 9T; Android 11; RKQ1.200826.002 test-keys; Flavour GooglePlay; MatrixAndroidSdk2 1.5.0)Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist