Enables New App Layout in Labs #7166
Conversation
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| <!-- Level 1: Labs --> | |||
| <bool name="settings_labs_thread_messages_default">false</bool> | |||
| <bool name="settings_labs_new_app_layout_default">false</bool> | |||
| <bool name="settings_labs_new_app_layout_default">true</bool> | |||
There was a problem hiding this comment.
The change is fine, but I do not think it will have an effect if the preference is already stored in the XML file of the user (I guess after the screen Labs settings has been displayed for the first time). Anyway I guess this is acceptable. Just to share this warning in case people do not understand why AppLayout is not enabled by default on their phone.
There was a problem hiding this comment.
It won't work only for people who changed value manually, means enabled AppLayout and then disabled it. For those who didn't change from default value it will work (tested)
There was a problem hiding this comment.
Cool, I was not sure. Then this is really fine!
fedrunov
added
the
Z-NextRelease
| @@ -50,7 +50,7 @@ import im.vector.app.withIdlingResource | |||
| import timber.log.Timber | |||
|
|
|||
| class ElementRobot( | |||
| private val labsPreferences: LabFeaturesPreferences = LabFeaturesPreferences(false) | |||
| private val labsPreferences: LabFeaturesPreferences = LabFeaturesPreferences(true) | |||
There was a problem hiding this comment.
Ah, I would also have forget to update this (2 sources of truth...). Thanks!
|
Kudos, SonarCloud Quality Gate passed!
|
|
The new layout is not ready yet and currently just an oversimplified and incomplete version of the old. I tried it in the last releases and immediately switched back because I couldn't switch spaces anymore or find my group chats which where being mixed into one list. |
Type of change
Content
Enables New App Layout in Labs (set default to true)
Motivation and context
Closes #7165
Screenshots / GIFs
Tests
Test this branch from having the labs flag disabled or clear your data and start the app from a fresh install. See that new app layout is enabled by default
Tested devices
Checklist