Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred DMs - Locals are not deleted anymore within the new AppLayout #7153

Closed
Florian14 opened this issue Sep 16, 2022 · 2 comments · Fixed by #7154
Closed

Deferred DMs - Locals are not deleted anymore within the new AppLayout #7153

Florian14 opened this issue Sep 16, 2022 · 2 comments · Fixed by #7154
Assignees
Labels
A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout Z-PS-Request

Comments

@Florian14
Copy link
Contributor

Florian14 commented Sep 16, 2022

Steps to reproduce

First bug:

  1. Start creating a DM with the start DM feature flag and the new App Layout enabled
  2. Abort the DM creation and go back to the home list
  3. Activate the recent rooms display from the AppLayout configuration
  4. Then, the local room appears in the recent rooms

Second bug:

  1. Start creating a DM with the start DM feature flag and the new App Layout enabled
  2. Write some text without sending it
  3. Abort the DM creation and go back to the home list
  4. Start creating again a DM with the same person
  5. Then, the local room is opened again with the drafted message

Outcome

What did you expect?

The local room should not be persisted anymore when the user is back to the room list

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes

@Florian14 Florian14 added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-DMs S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-AppLayout Z-PS-Request labels Sep 16, 2022
@Florian14 Florian14 self-assigned this Sep 16, 2022
@daniellekirkwood
Copy link
Contributor

This feels like good default behaviour (if the user is part way thru crafting a message, wants to switch rooms and then go back to that message, they are able to do so...)

@giomfo as someone close to the behaviour of start a DM (and acting PM!) what do you think? :D

@giomfo
Copy link
Member

giomfo commented Sep 16, 2022

This feels like good default behaviour (if the user is part way thru crafting a message, wants to switch rooms and then go back to that message, they are able to do so...)

I agree the second "bug" described here looks like an expected behavior, but it was not planned in this first implementation. We decided to fix/remove it for the moment to prevent us from unstable behavior.
We would have to work on this use case. FYI we already discussed about this point in Element-web repo here. The plan would be to be able to rescue the pending message but keeping hidden the "local"(uncreated) room

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout Z-PS-Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants