[New Layout] Adds peek height (min height) to new layout bottom sheets #7103
Conversation
| import androidx.annotation.FloatRange | ||
| import com.google.android.material.bottomsheet.BottomSheetDialog | ||
|
|
||
| @Suppress("DEPRECATION") |
There was a problem hiding this comment.
WindowManager. defaultDisplay and getMetrics are deprecated in 30. Could you add API 30 implementation? And also, please, use suppress on a line, where it's needed, not on whole function
| } else { | ||
| setPeekHeightPreApi30(percentage) | ||
| } | ||
| } |
There was a problem hiding this comment.
I would rather create an extension getScreenheightPx() to get the Window height, which will be more reusable.
Then just call
val height = window?.getScreenheightPx()
behavior.setPeekHeight((height * percentage).toInt(), true)
here.
We have some equivalent code at this point: https://github.com/vector-im/element-android/blob/main/vector/src/main/java/im/vector/app/features/roomprofile/uploads/media/RoomUploadsMediaFragment.kt#L86
It would deserve a quick refactor to extract useful and reusable and compatible extensions, in the package im.vector.app.core.extensions. Happy to do it later if you do not have time.
| return super.onCreateDialog(savedInstanceState).apply { | ||
| (this as BottomSheetDialog).setPeekHeightAsScreenPercentage(0.5f) | ||
| } | ||
| } |
There was a problem hiding this comment.
All those new BottomSheet should extend VectorBaseBottomSheetDialogFragment, for analytics support and common behavior. This specific treatment could then be moved to the parent, to avoid code duplication.
There was a problem hiding this comment.
Happy to make the changes 👍
…ape-bottom-sheet-peek # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/home/NewChatBottomSheet.kt
|
SonarCloud Quality Gate failed. |
Type of change
Content
Adds peek height to new layout bottom sheets so they don't show at heights smaller than they should be
Motivation and context
Fixes #7027
Screenshots / GIFs
Tests
Tested devices
Checklist