Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoplayed animated sticker #6982

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

p1gp1g
Copy link
Contributor

@p1gp1g p1gp1g commented Aug 31, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

It removes the play button on animated stickers and increase the stickers size.

Motivation and context

  • ATM, auto-played animated stickers are indeed auto-played but the play button is shown above it
  • Stickers are very small, the same size than emojis sent alone

Screenshots / GIFs

Before After
screen2 screen1
Screenshot_20220831-230338_Element dbg Screenshot_20220831-230920_Element dbg

For information, on iOS it looks like this:

Tested devices

  • Physical
  • Emulator
  • OS version(s): 12

Checklist

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new PR.
I do not really remember why we decided to limit the sticker size. No clue after a quick search in the history. Anyway since this is a dedicated commit, it will be easy to revert if necessary.

@bmarty bmarty merged commit ed13177 into element-hq:develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants