Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes #6967

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Fix crashes #6967

merged 3 commits into from
Aug 31, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 30, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR fixes some crashes, this commit message for the details.

Motivation and context

Less crashes.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from a team and fedrunov and removed request for a team August 30, 2022 12:50
@ElementBot
Copy link

Warnings
⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt#L1125 - Prefer "SHOW_AS_ACTION_IF_ROOM" instead of "SHOW_AS_ACTION_ALWAYS"

⚠️

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt#L1125 - Prefer "SHOW_AS_ACTION_IF_ROOM" instead of "SHOW_AS_ACTION_ALWAYS"

Generated by 🚫 dangerJS against b18395f

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 0950e41 into develop Aug 31, 2022
@bmarty bmarty deleted the feature/bma/fix_crashes branch August 31, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants