Target API 32 (Android 12) #6929

bmarty · 2022-08-24T14:38:40Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Fix #6863

Motivation and context

Support the latest stable version. Unblock some dependency upgrades.

Screenshots / GIFs

Tests

Sanity test

Smoke test

Limitations:

Left Drawer in room list: less accessible. User has to long click on the left then swipe to open it. Else clicking on the burger menu at top left.
Left Drawer in room timeline: breadcrumbs cannot be accessed easily. This is covered by Remove Breadcrumbs #2996. Anyway those breadcrumbs will be removed from their current place with the work about AppLayout.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

bmarty · 2022-08-29T12:39:12Z

Blocked for task ./gradlew instrumentationTestsWithCoverage :

Here are the logs:

* What went wrong:
Execution failed for task ':element-android:vector:mergeExtDexGplayDebug'.
> Could not resolve all files for configuration ':element-android:vector:gplayDebugRuntimeClasspath'.
   > Failed to transform emoji-google-release.aar (com.vanniktech:emoji-google-android:0.15.0) to match attributes {artifactType=android-dex, asm-transformed-variant=NONE, dexing-enable-desugaring=true, dexing-is-debuggable=true, dexing-min-sdk=21, org.gradle.category=library, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=androidJvm}.
      > Execution failed for JacocoTransform: /Users/bmarty/.gradle/caches/transforms-3/8342f4aa3442dc9eb1c78fe1c6583e69/transformed/jetified-emoji-google-release-runtime.jar.
         > org.gradle.internal.operations.BuildOperationInvocationException (no error message)
...
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':element-android:vector:mergeExtDexGplayDebug'.
...
Caused by: org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':element-android:vector:gplayDebugRuntimeClasspath'.
...
Caused by: org.gradle.api.internal.artifacts.transform.TransformException: Failed to transform emoji-google-release.aar (com.vanniktech:emoji-google-android:0.15.0) to match attributes {artifactType=android-dex, asm-transformed-variant=NONE, dexing-enable-desugaring=true, dexing-is-debuggable=true, dexing-min-sdk=21, org.gradle.category=library, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=androidJvm}.
...
Caused by: org.gradle.api.internal.artifacts.transform.TransformException: Execution failed for JacocoTransform: /Users/bmarty/.gradle/caches/transforms-3/8342f4aa3442dc9eb1c78fe1c6583e69/transformed/jetified-emoji-google-release-runtime.jar.
...
Caused by: org.gradle.internal.operations.BuildOperationInvocationException
 ...
Caused by: java.io.IOException: Error while instrumenting com/vanniktech/emoji/google/category/SmileysAndPeopleCategoryChunk2.class.
...
Caused by: org.objectweb.asm.MethodTooLargeException: Method too large: com/vanniktech/emoji/google/category/SmileysAndPeopleCategoryChunk2.<clinit> ()V
...

So this class constructor is too big: https://github.com/vanniktech/Emoji/blob/master/emoji-google/src/commonMain/kotlin/com/vanniktech/emoji/google/category/SmileysAndPeopleCategoryChunk2.kt#L22

I will open an issue there, the chunk2 should be probably split into smaller chunks...

Bumps appcompat from 1.4.2 to 1.5.0. --- updated-dependencies: - dependency-name: androidx.appcompat:appcompat dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps emoji2 from 1.1.0 to 1.2.0. --- updated-dependencies: - dependency-name: androidx.emoji2:emoji2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…help to detect other deprecated API usage.

… from being backed up. Also properly support Android 11.

WARNING:API 'ApkVariantOutput.getVersionCodeOverride()' is obsolete and has been replaced with 'VariantOutput.versionCode()'.

…2.43.2

bmarty · 2022-09-16T21:31:37Z

Unblocked using a SNAPSHOT version, which is not ideal (non reproductible build), but this is a temporary measure.

…branch...

…se positive `UnusedResources` issues.

ElementBot · 2022-09-19T10:24:07Z

	Warnings
⚠️	library/attachment-viewer/src/main/java/im/vector/lib/attachmentviewer/AttachmentViewerActivity.kt#L123 - Custom view `FrameLayout` has `setOnTouchListener` called on it but does not override `performClick`
⚠️	library/attachment-viewer/src/main/java/im/vector/lib/attachmentviewer/AttachmentViewerActivity.kt#L123 - Custom view `FrameLayout` has `setOnTouchListener` called on it but does not override `performClick`
⚠️	vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L206 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L206 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L260 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L260 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L269 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L269 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L276 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L276 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L282 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L282 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L400 - Exported receiver does not require permission
⚠️	vector/src/main/AndroidManifest.xml#L400 - Exported receiver does not require permission

Generated by 🚫 dangerJS against b9c28ba

ericdecanini · 2022-09-21T14:17:28Z

...y/attachment-viewer/src/main/java/im/vector/lib/attachmentviewer/AttachmentViewerActivity.kt

-                @SuppressLint("WrongConstant")
-                window.decorView.windowInsetsController?.systemBarsBehavior = WindowInsetsController.BEHAVIOR_SHOW_BARS_BY_SWIPE
-            }
+            window.decorView.windowInsetsController?.systemBarsBehavior = WindowInsetsController.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE


Nit: Much of this looks similar to the same code in VectorBaseActivity. Is there a way we can reduce the duplication?

Yes, when we will have a core module.

ericdecanini · 2022-09-21T14:18:23Z

...r/src/main/java/im/vector/app/features/roomprofile/uploads/media/RoomUploadsMediaFragment.kt

+            val a = requireActivity().windowManager.currentWindowMetrics
+            a.bounds.width()


Nit: I don't think the variable serves any value here

yes, it's assigned to val screenWidthInPx.

sonarcloud · 2022-09-21T15:02:16Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

This was referenced Aug 25, 2022

Bump appcompat from 1.4.2 to 1.5.0 #6931

Closed

Bump emoji2 from 1.1.0 to 1.2.0 #6933

Closed

bmarty mentioned this pull request Aug 29, 2022

SmileysAndPeopleCategoryChunk2 constructor is too big for task instrumentationTestsWithCoverage when using gradle 7.2.2 vanniktech/Emoji#883

Closed

bmarty mentioned this pull request Sep 8, 2022

Bump appcompat from 1.4.2 to 1.5.1 #7075

Closed

bmarty force-pushed the feature/bma/android12 branch from b4b6afd to 7e81868 Compare September 12, 2022 15:41

dependabot bot and others added 16 commits September 16, 2022 23:00

Bump appcompat from 1.4.2 to 1.5.0

ea274c4

Bumps appcompat from 1.4.2 to 1.5.0. --- updated-dependencies: - dependency-name: androidx.appcompat:appcompat dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump emoji2 from 1.1.0 to 1.2.0

d9ee51a

Bumps emoji2 from 1.1.0 to 1.2.0. --- updated-dependencies: - dependency-name: androidx.emoji2:emoji2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

'compileSdk': 32, 'targetSdk': 32

8b64bd3

Remove deprecated internal class.

3f3c83a

Stop using deprecated method.

24e4f94

Move @Suppress("DEPRECATION") closer to the deprecated usage. Will …

536b9cf

…help to detect other deprecated API usage.

Reduce level API check, this seems not necessary.

e17f009

Reduce level API check, this seems not necessary.

518ec73

Restore this annotation

cde7096

Reduce level API check, this seems not necessary.

88482c9

Add dataExtractionRules, applicable to Android 12. Exclude everything…

842a9bb

… from being backed up. Also properly support Android 11.

Upgrade gradle plugin from 7.1.3 to 7.2.2

c5571c0

Fix gradle warning:

57db43c

WARNING:API 'ApkVariantOutput.getVersionCodeOverride()' is obsolete and has been replaced with 'VariantOutput.versionCode()'.

Upgrade kotlin from 1.6.21 to 1.7.10 and dagger (+hilt) from 2.42 to …

892484a

…2.43.2

App compat 1.5.1

84afa47

Use vanniktechEmoji "0.16.0-SNAPSHOT"

a1f4ffb

bmarty force-pushed the feature/bma/android12 branch from 7e81868 to a1f4ffb Compare September 16, 2022 21:12

Changelog

d4eb619

bmarty marked this pull request as ready for review September 16, 2022 21:30

bmarty requested review from a team and ericdecanini and removed request for a team September 16, 2022 21:30

Fix lint warnings, some code has vanished dur to the rebasing of the …

c91ba06

…branch...

bmarty changed the title ~~Target API 32 (Android 12) - WIP~~ Target API 32 (Android 12) Sep 19, 2022

bmarty added the Z-Merge After Release label Sep 19, 2022

Move xml resource in the module where they are used to avoid lint fal…

e2d131f

…se positive `UnusedResources` issues.

ericdecanini approved these changes Sep 21, 2022

View reviewed changes

Merge branch 'develop' into feature/bma/android12

b9c28ba

bmarty merged commit 151f624 into develop Sep 22, 2022

bmarty deleted the feature/bma/android12 branch September 22, 2022 14:30

Graphicscore mentioned this pull request Mar 27, 2023

Failed to resolve: com.vanniktech:ui causes the app Graddle Sync failure #8280

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Target API 32 (Android 12) #6929

Target API 32 (Android 12) #6929

bmarty commented Aug 24, 2022 •

edited

Loading

bmarty commented Aug 29, 2022 •

edited

Loading

bmarty commented Sep 16, 2022

ElementBot commented Sep 19, 2022 •

edited

Loading

ericdecanini Sep 21, 2022

bmarty Sep 22, 2022

ericdecanini Sep 21, 2022

bmarty Sep 22, 2022

sonarcloud bot commented Sep 21, 2022

		val a = requireActivity().windowManager.currentWindowMetrics
		a.bounds.width()

Target API 32 (Android 12) #6929

Target API 32 (Android 12) #6929

Conversation

bmarty commented Aug 24, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

bmarty commented Aug 29, 2022 • edited Loading

bmarty commented Sep 16, 2022

ElementBot commented Sep 19, 2022 • edited Loading

ericdecanini Sep 21, 2022

Choose a reason for hiding this comment

bmarty Sep 22, 2022

Choose a reason for hiding this comment

ericdecanini Sep 21, 2022

Choose a reason for hiding this comment

bmarty Sep 22, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Sep 21, 2022

bmarty commented Aug 24, 2022 •

edited

Loading

bmarty commented Aug 29, 2022 •

edited

Loading

ElementBot commented Sep 19, 2022 •

edited

Loading