Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug Icon UX Improvements & Addition in New Layout #6871

Merged
merged 8 commits into from
Aug 22, 2022
Merged

Debug Icon UX Improvements & Addition in New Layout #6871

merged 8 commits into from
Aug 22, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Aug 18, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Debug icon now refreshes visibility in onResume so you don't have to restart the app after enabling Developer Mode
  • Debug icon added to New App Layout
  • New App Layout flag changes take place without having to restart

Motivation and context

Closes #6867

Screenshots / GIFs

image

Tests

  • Enable developer mode
  • Without restarting, go back to home screen and see debug icon
  • Go to debug icon > features > enable new app layout
  • Go back without restarting and see new app layout
  • See that new app layout also has debug icon in the toolbar
  • Disable new app layout and without restarting see that you're back in the old app layout

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini ericdecanini changed the base branch from develop to feature/eric/new-layout-navigation August 18, 2022 08:17
@ericdecanini ericdecanini requested review from a team, onurays and fedrunov and removed request for a team August 18, 2022 08:18
@ericdecanini ericdecanini marked this pull request as ready for review August 18, 2022 08:52
onurays
onurays approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@onurays
Copy link
Contributor

onurays commented Aug 19, 2022

Can you solve lint problems before merging?

@ericdecanini
Fixes documentation lint errors
1bd46e9
@ericdecanini
Merge branch 'feature/eric/new-layout-navigation' into feature/eric/n…
add7bd9 
…ew-layout-debug

# Conflicts:
#	vector/src/test/java/im/vector/app/features/navigation/DefaultNavigatorTest.kt
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
4.8% 4.8% Duplication

fedrunov
fedrunov approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vector/src/main/java/im/vector/app/features/home/HomeActivity.kt
@@ -138,6 +139,8 @@ class HomeActivity :
@Inject lateinit var fcmHelper: FcmHelper
@Inject lateinit var nightlyProxy: NightlyProxy

private var isNewAppLayoutEnabled: Boolean = false // delete once old app layout is removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT (merge without addressing): better reference a line of code or issue, so it will be possible to check this condition. Here it could be an app layout flag

@ericdecanini ericdecanini merged commit 86438cf into feature/eric/new-layout-navigation Aug 22, 2022
@ericdecanini ericdecanini deleted the feature/eric/new-layout-debug branch August 22, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedrunov fedrunov fedrunov approved these changes

@onurays onurays onurays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space Switching: Debug Menu
3 participants
@ericdecanini @onurays @fedrunov