Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Login has disappeared from the app, both Android and iOS #6827

Closed
catalyst-eu opened this issue Aug 13, 2022 · 1 comment · Fixed by #6834
Closed

SSO Login has disappeared from the app, both Android and iOS #6827

catalyst-eu opened this issue Aug 13, 2022 · 1 comment · Fixed by #6834
Assignees
Labels
A-Onboarding O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-FTUE Issue is relevant to the first time use project or experience

Comments

@catalyst-eu
Copy link

Steps to reproduce

  1. I load the app and give our company Matrix URL
  2. There used to be a "login with SSO" in the app. In the browser it is still there, but the app doesn't have it.
  3. As a result, I can no longer login to Matrix/Element

Outcome

What did you expect?

A button "Login with SSO".

What happened instead?

The button is not there. There's only the option to login with username and password, but that doesn't work for us.

Your phone model

Any Android phone

Operating system version

Any android OS

Application version and app store

1.4.32

Homeserver

Synapse 1.4.0

Will you send logs?

No

Are you willing to provide a PR?

No

@catalyst-eu catalyst-eu added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 13, 2022
@hughns
Copy link
Member

hughns commented Aug 14, 2022

I've come across what I think might be the same issue in the OIDC Playground.

Test homeserver: https://synapse-oidc.lab.element.dev

Here is how it looks on app.element.io which is what I expect:
image

On iOS the SSO button is missing:
image

And on Android it is also missing:
image

The issue is triggered by having https://synapse-oidc.lab.element.dev/_matrix/client/v3/login returning m.login.sso but without the identity_providers value being set.

The spec says that identity_provider is optional.

I have a patch that fixes the behaviour on Android:

image

I haven't found the appropriate place for iOS.

@ouchadam ouchadam self-assigned this Aug 15, 2022
@ouchadam ouchadam added Z-FTUE Issue is relevant to the first time use project or experience S-Critical Prevents work, causes data loss and/or has no workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Onboarding labels Aug 15, 2022
@daniellekirkwood daniellekirkwood changed the title SSO Login has disappeared from the app, both Android and OIS SSO Login has disappeared from the app, both Android and iOS Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Onboarding O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants