Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Switching: Bottom Sheet Doesn't Always Measure Properly #6750

Closed
Tracked by #6605
ericdecanini opened this issue Aug 5, 2022 · 0 comments · Fixed by #6928
Closed
Tracked by #6605

Space Switching: Bottom Sheet Doesn't Always Measure Properly #6750

ericdecanini opened this issue Aug 5, 2022 · 0 comments · Fixed by #6928
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Delight Z-AppLayout

Comments

@ericdecanini
Copy link
Contributor

ericdecanini commented Aug 5, 2022

Following the work from #6749

There are times where you open the bottom sheet but it fails to load with the proper size and the result is a small sheet that doesn't fit the spaces that occupy the list.

This seems to be a race condition between how long it takes for the sheet to measure and the epoxy controller to inflate the list. A possible cause is because setState is initially called in the view model without any spaces before it is called again later with the spaces that inflate the list, which would tell the controller to initially update without any spaces.

Expected Actual

Parent epic: #6605

Steps to reproduce

Just keep opening the space sheet and switching betweens spaces until it occurs

The frequency of it can be pretty random, and it's a bit intermittent but common enough to be noticeable

@ericdecanini ericdecanini added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Team: Delight Z-AppLayout labels Aug 5, 2022
@ericdecanini ericdecanini self-assigned this Aug 5, 2022
@ericdecanini ericdecanini changed the title Space Switching: Bottom Sheet doesn't always measure properly Space Switching: Bottom Sheet Doesn't Always Measure Properly Aug 17, 2022
@fedrunov fedrunov assigned fedrunov and unassigned ericdecanini Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Delight Z-AppLayout
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants